Fix negative values in BarChart #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaNNeo
changed the title
toY (or positive fromY) in BarChart's minY …
Codecov Report
@@ Coverage Diff @@
## master #1486 +/- ##
==========================================
+ Coverage 86.63% 86.67% +0.03%
==========================================
Files 45 45
Lines 3015 3016 +1
==========================================
+ Hits 2612 2614 +2
+ Misses 403 402 -1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
…and `maxY` calculations, #1470
imaNNeo
force-pushed
the
bugfix/bar-chart-negative-issue
branch
from
2df5734 to
c97749d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toY(or positivefromY) in BarChart'sminYandmaxYcalculations, BackgroundBarChartRodData with negative values broke in 0.64.0 #1470