-
Notifications
You must be signed in to change notification settings - Fork 5
feat: implement perspective warp #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 98.48% 97.50% -0.98%
==========================================
Files 245 246 +1
Lines 10035 10269 +234
Branches 2146 2165 +19
==========================================
+ Hits 9883 10013 +130
- Misses 152 256 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently, there is only the test case from the issue but the implementation right now seems to be identical to the openCV implementation when nearest neighbor interpolation is used. Besides adding more test cases, should there be an option that allows the choice of interpolation? |
The initial idea was to implement a function which returns a transform matrix like OpenCV does, and to use that transform matrix to create the new image using The |
There is a function in legacy version that calculates width and height with respect of image's aspect ratio. Is it okay to remove the function that calculates width and height to preserve ratio of the image and just specify desired width and height? openCV version doesn't have one, you need to put destination corner points there. We could do a function with 4 source points and 4 destination points. |
Also the transform() function currently accepts 2x3 matrices for affine transformations. Should i modify the code so that it accepts only 3x3 matrices or it should accept both, and if input matrix is 2x3 i just add another row? After all, if i understand correcly, affine transformation is perspective transformation with [0,0,1] as last matrix row |
After discussion with @stropitek we decided to have a |
No description provided.