Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzzing code for cargo-fuzz #116

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Add fuzzing code for cargo-fuzz #116

merged 5 commits into from
Dec 23, 2021

Conversation

HeroicKatora
Copy link
Member

@HeroicKatora HeroicKatora commented Sep 17, 2021 •
edited
Loading

@HeroicKatora HeroicKatora marked this pull request as draft September 17, 2021 21:22
@HeroicKatora HeroicKatora marked this pull request as ready for review September 17, 2021 22:00
@HeroicKatora
Copy link
Member Author

HeroicKatora commented Sep 19, 2021 •
edited
Loading

Benchmark report. This seems to regress the use case where only meta data is gathered, probably due to the allocation. I do favor correctness over performance here (we're still in gigabyte speed) but that's ~40%.

# Comparing origin/master with origin/fuzz
[Benchmark]              	[Change] 	[Base]  	[Head]  	[Significance]
gif/note.gif/727554      	         	9.628048	9.586300	0.050000
gif/photo.gif/10130100   	         	110.092727	109.240000	0.050000
gif/sample_1.gif/69      	         	1.398930	1.403600	0.050000
gif/sample_big.gif/751774	         	326.643203	325.430000	0.050000
gif/extract-metadata-note	regressed	326.655382	477.720000	0.050000

@HeroicKatora
Add fuzzing code for cargo-fuzz
01e673f
@HeroicKatora
Add fuzz code for decode
2819964
@HeroicKatora
Fix infinite loop during decoding
0de672c 
In frames with empty image data it was possible to trigger a condition
where decoding would be stuck, neither reading any part of the data nor
producing any LZW decoded data. The outer loop expects to make progress
and odes not have any alternative stop condition. This was an infinite
blocking loop.
@HeroicKatora
Avoid allocation in empty max_bytes case
6429310
@HeroicKatora HeroicKatora reopened this Dec 23, 2021
@HeroicKatora
Copy link
Member Author

The extract-metadata-note seems to be too noisy due to some external influence. Anyways, I'd suggest ignoring it for now as this is a correctness fix.

@HeroicKatora HeroicKatora merged commit fca7964 into master Dec 23, 2021
@HeroicKatora HeroicKatora deleted the fuzz branch December 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang when iterating over frames of a malformed file
1 participant
@HeroicKatora