Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate LZW compression from writing for parallel encoding #140

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

kornelski
Copy link
Contributor

Fixes #42

Adds write_lzw_pre_encoded_frame function that takes an already-compressed LZW data. This allows the caller to perform compression separately, e.g. using a thread pool to compress multiple frames in parallel.

The Frame docs say the buffer could be something else, so I'm taking advantage of that to smuggle the LZW data in there.

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. And what a nice coincidence that the documentation already hints at this possibility 😄

@kornelski
Copy link
Contributor Author

What are your plans for merging and releasing this?

@HeroicKatora HeroicKatora merged commit 03b63f0 into image-rs:master Oct 7, 2022
@HeroicKatora
Copy link
Member

What are your plans for merging and releasing this?

Soon, but rather as 0.12. The feature change in color quant is not 100% compatible (if default-features = false is being used) and even this seems major enough to require some level of awareness.

@kornelski kornelski deleted the parallel-encode branch October 8, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel encoding?
2 participants