Add support for parsing mDCv and cLLi chunks.
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new test is based on the |
anforowicz
force-pushed
the
clli-and-mdcv-chunks
branch
2 times, most recently
from
55fa683
to
c507ed0
Compare
fintelia
approved these changes
Oct 31, 2024
This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/376550658.
anforowicz
force-pushed
the
clli-and-mdcv-chunks
branch
from
c507ed0
to
1482de3
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 19, 2024
This CL patches the `png` crate in a way that corresponds to the following upstream PRs: * image-rs/image-png#526 - baseline to make subsequent patches easier to apply * image-rs/image-png#528 - `mDCv` and `cLLI` * image-rs/image-png#529 - `cICP` This CL is a prerequisite for rolling Skia beyond http://review.skia.org/917216 Bug: chromium:376758571 Bug: chromium:376550658 Change-Id: I5a70fccd71ae4295b62f7291a5fd3809f0d53860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999738 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/main@{#1385066}
hubot
pushed a commit
to google/skia
that referenced
this pull request
Nov 21, 2024
This CL propagates the data from the `cICP` chunk into `SkEncodedInfo::ICCProfile`. Dependencies: * This CL unblocks enabling the `PNGTests.cicp` test in the Chromium CL at https://crrev.com/c/6013356. * This CL depends on the new `SkColorSpace::MakeCICP` API that was recently added in https://crrev.com/c/5999738. This CL patches the `png` crate in a way that corresponds to the following upstream PRs (rolling this CL into Chromium depends on https://crrev.com/c/5999738 which included the same patches): * image-rs/image-png#526 - baseline to make subsequent patches easier to apply * image-rs/image-png#528 - `mDCv` and `cLLI` * image-rs/image-png#529 - `cICP` Bug: chromium:376758571 Change-Id: I1e550b1eba4d629ff4337d85daa5656ac03f3a5a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/917216 Commit-Queue: Łukasz Anforowicz <lukasza@google.com> Reviewed-by: Daniel Dilan <danieldilan@google.com>
ocpkn
pushed a commit
to ocpkn/image-png
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL?
This PR is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/376550658.
IIUC Chromium and Blink only require an ability to decode these chunks - there is no need for encoding support (e.g. the search query here only finds decoder bits).