Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to the blog #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add link to the blog #6

wants to merge 2 commits into from

Conversation

HeroicKatora
Copy link
Member

No description provided.

JohnTitor
JohnTitor approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's helpful that we have a screenshot displays change but it looks good to me.

@HeroicKatora
Copy link
Member Author

HeroicKatora commented Oct 4, 2019 •
edited
Loading

Just tested it on mobile and the new banner part overlaps. (Should have properly learned responsive design afterall). Some chromium devtool screenshots for various display sizes attached.

new_banner
new_banner_1440
new_banner_(iPhone 5_SE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeroicKatora @JohnTitor