Simplify expand_strip #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
commented
Apr 11, 2021
| | (ColorType::CMYK(16), DecodingBuffer::I16(ref mut buffer)) => { | ||
| reader.read_i16_into(&mut buffer[..bytes / 2])?; | ||
| bytes / 2 | ||
| for b in &mut buffer[bytes_written..] { |
There was a problem hiding this comment.
This addresses the FIXME from line 932
fintelia
force-pushed
the
simplify-expand3
branch
from
201826b to
201b95f
Compare
Farkal
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the strip decoding logic with the goal of making it simpler and easier to modify.