Fix bugs, compiler warnings and add tests #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Limits
struct to fix the memory exhaustion bug in #29, this changes the public API slightly, becauseifd::Entry::val
now also needs aLimits
parameter. It adds some array bounds checking for indices that directly come from the tiff file. While I was at it I also fixed #13 by changingDecoder::read_string
to return aTiffResult
instead of aFromUtf8Error
result. I also fixed some smaller compiler and clippy warnings.I added the samples from #28, #29 and #31 as new tests, thank you @Shnatsel!
This will fix #13, fix #28, fix #29, fix #30 and fix #31.
@Robzz and @HeroicKatora what do you think of this?