Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DynamicImage non-exhaustive #1632

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

HeroicKatora
Copy link
Member

As suggested by @5225225. Downstream code exhaustive matching on the current variants should use or petition for methods that extract into one types instead. Of particular note and example I'd like to point out [as_bytes] which essentially promises that all future variants will only contain matrices of trivial and padding-free channel types.

Overall, it's expected that this allows 0.24 to be more stable while we may discuss how to introduce half-float, or non-rgb combinations.

@fintelia
Copy link
Contributor

fintelia commented Dec 3, 2021

Overall, it's expected that this allows 0.24 to be more stable while we may discuss how to introduce half-float, or non-rgb combinations.

And of course whether we should introduce half-float or non-rgb combinations 😄

@HeroicKatora HeroicKatora merged commit 87bf1ac into image-rs:master Dec 3, 2021
@HeroicKatora HeroicKatora deleted the non-exhaustive-dynimage branch February 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants