Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra sanity checks in bmp and ico decoders #632

Merged
merged 8 commits into from
Jul 30, 2017
Merged

Add extra sanity checks in bmp and ico decoders #632

merged 8 commits into from
Jul 30, 2017

Commits on Mar 25, 2017

  1. Add more checks to bmp decoder and limit the starting buffer size + m… 

    …inor optimization.

This commit adds some size limits to the decoder, limits the palette buffer size, and limits the starting pixel buffer size to avoid OOM issues.
Additionally, this adds a small optimisation to read_full_byte_pixel_data by reducing the number of read calls, which improves the performance of decoding images with plain 8-bit r/g/b/a values.
This commit also fixes the compilation of benchmarks which was broken.
    @oyvindln
    oyvindln committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    f632754 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2017

  1. Add more checks in the ICO decoder

    @oyvindln
    oyvindln committed Mar 26, 2017
    Configuration menu
    Copy the full SHA
    669c081 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. Add a tests for very large palette/width/height values

    @oyvindln
    oyvindln committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    2197ef3 View commit details
    Browse the repository at this point in the history

  2. Fix test + decode rle delta codes properly

    @oyvindln
    oyvindln committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    364e7db View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2017

  1. Avoid panicking and pass truncate test + remove leftover commented ou… 

    …t code
    @oyvindln
    oyvindln committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    487be3e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2017

  1. Remove commented code + add a basic check for EoF in RLE-files.

    @oyvindln
    oyvindln committed May 2, 2017
    Configuration menu
    Copy the full SHA
    4320ac6 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. Merge branch 'master' of https://github.com/PistonDevelopers/image in… 

    …to fuzz-fixes
    @oyvindln
    oyvindln committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    7c61a90 View commit details
    Browse the repository at this point in the history

  2. Fix stuff broken in merge

    @oyvindln
    oyvindln committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    96a976b View commit details
    Browse the repository at this point in the history