Use the 'Wrapping' integer type instead of wrapping methods in IDCT #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IDCT code is full of wrapping integer arithmetic. This commit changes the code to use std::num::Wrapping instead of i32::wrapping_* methods. This is a big commit in term of number of lines changed, but this should have absolutely no impact on the generated machine code. This just makes the IDCT code much easier to read, which should in turn make it easier to optimize.
HeroicKatora
approved these changes
Apr 14, 2020
wartmanm
pushed a commit
to wartmanm/jpeg-decoder
that referenced
this pull request
Oct 4, 2021
Use the 'Wrapping' integer type instead of wrapping methods in IDCT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDCT code is full of wrapping integer arithmetic.
This commit changes the code to use
std::num::Wrappinginstead ofi32::wrapping_*methods.This is a big commit in term of number of lines changed, but this should have absolutely no impact on the generated machine code.
This just makes the IDCT code much easier to read, which should in turn make it easier to optimize.