Speed up display of SCIFIOCellImg (depends on PR in imglib2-ij) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gePlus This speeds up the conversion of CellImg to ImagePlus. It only has an effect if the cells are planar. This is often the case when SCIFIOCellImage is used.
|
Thanks, @maarzt. Please ping me again when imglib/imglib2-ij#22 has merged and this PR is finalized, and I'll look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on a PR in imglib2-ij: imglib/imglib2-ij#22
A cell image with planar cells has the same memory organization as an ImagePlus.
SCIFIOCellImage (which often or allways??) uses planar cells can therefor converted to ImagePlus without the copying of any pixel buffer. This PR removes such superfluous copy operation, and should result in a faster display of SCIFIOCellImg and faster operations with legacy code.