Use non-normalized normals in Mesh centroid #655
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the fixes I discussed with @tibuch on Zulip (here), while trying to determine the difference in return between the
geom.centroid
Op operating onMesh
es and the static algorithmMeshStats.centroid()
from imglib2-mesh. This change does not need to be ported forward to SciJava Ops Image, as it is our plan to remove these Ops entirely, instead leaning upon imglib2-mesh (where we'd just useMeshStats.centroid()
)The reason for the draft PR is that I am unsure how to fix the tests - there are three failures in Mesh features that depend upon the centroid Op which fail with these changes, and two suggest that the values were verified against MATLAB. I don't know which MATLAB code was used/how to verify.