Add logic for migrating to Jaunch launcher #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ctrueden
commented
Nov 19, 2024
ctrueden
commented
- Update license blurbs for 2024
- ImageJUpdater: let any/all services be null
- ImageJUpdater: Do not update the updater separately
- WIP: Add logic for migrating to Jaunch launcher
The code was already written to support the services not being set, with various fallbacks in place. So let's mark the params accordingly.
The removed code does the following:
* check if the updater can be updated
* if yes, download updater and it's dependencies and install it,
do not ask for approval
* try to restart the updater in place
* if that does not work, ask for restart of Fiji
This is why it should be removed:
* if other components depend on the updater, this can break the installation
because the other component will not get updated at the same time as the updater
* the updater will be updated without the users approval
CTR: I asked Johannes why this logic was introduced. Here is what he said:
> The reason was dependency hell. If you don't update the updater first,
> then create a new class loader, then re-load the updater and run it,
> it really can break everything, especially when imagej-ui-swing is
> updated (and not necessarily the updater).
CTR: So really, there are things that can go wrong either way. In the
interest of simplicity, we remove the logic. If all hell breaks loose,
we can put it back, and deal with the fallout as best we can. But I
expect that removing this logic will fix more problems than it causes.
Closes #83.
Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
ctrueden
force-pushed
the
new-launcher
branch
5 times, most recently
from
7e3a1fe
to
6cfcad4
Compare
ctrueden
force-pushed
the
new-launcher
branch
from
4c3fc6e
to
cb78283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.