Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the license #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the license #131

wants to merge 1 commit into from

Conversation

1000ch
Copy link
Contributor

@1000ch 1000ch commented Nov 12, 2021

To fix #103.

@1000ch 1000ch requested a review from XhmikosR November 12, 2021 06:54
@XhmikosR
Copy link
Contributor

Not sure this is needed and I'm not a lawyer :P

I mean, most of the tools' code isn't MIT (jpegoptim, optipng etc) and we don't treat them differently.

So, whatever the choice here is, it should be done in all repos.

@1000ch
Copy link
Contributor Author

1000ch commented Nov 12, 2021

most of the tools' code isn't MIT (jpegoptim, optipng etc) and we don't treat them differently.
So, whatever the choice here is, it should be done in all repos.

I understand the point, we decided to respect the original license at imagemin/pngquant-bin#105 besides this. Maybe better to fix those repos accordingly?

package.json Outdated Show resolved Hide resolved
@@ -1,9 +1,343 @@
MIT License
Node.js wrapper is implemented by Imagemin team and distributed under the MIT License. The Gifsicle code is Copyright (C) 1997-2021 Eddie Kohler and distributed under the GNU General Public License, Version 2 (and only Version 2) as below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this information is incomplete. See https://github.com/kohler/gifsicle#copyrightlicense

I would also challenge that you can build an MIT wrapper around a GPL component. If that would work I would write MIT wrappers for everything. A proper fix would be to license the project under GPL-2.0-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License issue
3 participants