Fail the postinstall script if compiling fails #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pngquant binary does not work and the compile fails, npm should fail the package installation, since it will not work. Previously it would log an error, but return exit code 0 so npm would think the package was installed correctly. This will make it easier for users to figure out why pngquant isn't working.
sindresorhus
changed the title
|
Please test npm install pngquant-bin on node:alpine or centos:7. It fails on both, though it does work on node:8.11.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pngquant binary does not work and the compile fails, npm should
fail the package installation, since it will not work. Previously it
would log an error, but return exit code 0 so npm would think the
package was installed correctly. This will make it easier for users to
figure out why pngquant isn't working.
Fixes #72