Add total measurement instrumentation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
approved these changes
Oct 22, 2021
pdobacz
pushed a commit
that referenced
this pull request
Oct 22, 2021
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
JacekGlen
pushed a commit
that referenced
this pull request
Jan 17, 2023
Prune gokzg from crypto/kzg
JacekGlen
pushed a commit
that referenced
this pull request
Jan 17, 2023
ethapi: Fix gas esitmation for blob txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before switching to two separate branches
wall clock-allandwallclock-total, let's add new field toInstrumenterLoggerand use it in both measurement types.This enables us to use just one branch in
gas-cost-estimatorand letmain.godecide which mode to run.Otherwise, it creates a couple of problems during compilation if we still wanted to keep just one branch in
gas-cost-estimator.