ハイコントラストテーマとライトテーマが壊れていた問題を修正 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lnanase
reviewed
Jul 2, 2018
app/javascript/styles/contrast.scss
Outdated
| @import 'imastodon/modal'; | ||
| @import 'imastodon/statuses'; | ||
| @import 'imastodon/trend_tags'; | ||
| @import 'imastodon/tutorial'; |
There was a problem hiding this comment.
theme_sidem_alte.scss のテーマファイルのように、下記を記述するのはいかがでしょうか？
@import 'theme_mastodon';
takayamaki
force-pushed
the
fix-some-theme
branch
2 times, most recently
from
23c4905
to
d198967
Compare
- お気に入りタグ周りでwhiteベタ書きしていた部分をprimary-text-colorに修正
takayamaki
force-pushed
the
fix-some-theme
branch
from
d198967
to
7748cdc
Compare
|
コードは問題ないですが、上にあるライトテーマのスクリーンショットで、△の折り畳みボタンが斜めになっているように見えますが大丈夫ですか？ |
|
単にスクリーンショットを撮ったタイミングによるものなので問題ないです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ハイコントラストテーマの公開範囲アイコンが背景と同化してしまっていますが、これは今小手先で直すというよりもscssのアイマストドン独自部分全体のリファクタリング案件だと思うので別途対応します。
ハイコントラストテーマ
ライトテーマ