Fixed setup_github_pages failing and not properly writing url to _config.yml #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing `rake setup_github_pages`, an error tells that `url` don't exist. The reference to that variable has been changed to a call to `blog_url`. The function `blog_url` was not returning anything, failing to properly write the `_config.yml` file. It now does return what should have.
| @@ -358,7 +358,7 @@ task :setup_github_pages, :repo do |t, args| | |||
| f.write rakefile | |||
| end | |||
| end | |||
| puts "\n---\n## Now you can deploy to #{url} with `rake deploy` ##" | |||
| puts "\n---\n## Now you can deploy to #{blog_url(user, project)} with `rake deploy` ##" | |||
There was a problem hiding this comment.
Why don't we store the return value of blog_url in the url variable and use it everywhere it's needed?
...and stored in the `url` variable.
|
May I count with this being merged or rejected some time from now? I would like to delete the fork someday. |
parkr
added a commit
that referenced
this pull request
Oct 23, 2014
Fixed setup_github_pages failing and not properly writing url to _config.yml
|
Sorry, must have gotten lost in the backlog! Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs:
blog_urlwasn't returning anything, so theurlfield of_config.ymlwas being emptied.blog_urlwas writing the URL with uppercase letters (e.g.,http://Darkhogg.github.io). Username is now downcased (project is not, I'm not sure if that would be required)setup_github_pageswas trying to print theurlvariable, which is undefined. It now callsblog_urlagain.I did not search through issues for all these bugs so I don't know if this would fix some open issue.