Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at a Slimmage Background Image plugin #55

Open
wants to merge 6 commits into
base: unstable
Choose a base branch
from

Conversation

protherj
Copy link

@protherj protherj commented Nov 5, 2015

This is my first attempt at a Background Images plugin based on the Pull Request #37 from dancek. Slimmage has changed considerably and I hope I got it generally right.

Two problems I'm currently having that I need help with:

  1. The var cssMaxWidth = s'getCssPixels'; call always returns null for me and that causes the getImageInfo to return null as well. Thus, the fall back to 3000 if falsy.

  2. The call to getImageInfo always seems to return an image with a width of 2048. It's probably my CSS setup somehow, but any help determining the cause would rock.

Also, is this plugin setup properly? I didn't have any examples to go off of, so any help with getting it right is appreciated.

Thanks

@lilith
Copy link
Member

lilith commented Nov 6, 2015

You need to have a max-width applied to the element for getCssPixels to work. If there's no constraint, it returns null. Nearly all frameworks include img {max-width:100%} as a sanity limit.

Likewise, a max of 2048 is the default configuration for maximum width.

@lilith
Copy link
Member

lilith commented Nov 6, 2015

You should be able to reset to the updated version of 'unstable' and get a cleaner PR. I apologize for 'unstable' being behind 'master'. No idea how that happened, but it is corrected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants