Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove any types #1152

Merged
merged 36 commits into from
Jul 27, 2022

Conversation

imbhargav5
Copy link
Owner

@imbhargav5 imbhargav5 commented Jul 23, 2022

There are quite a few errors after I added noImplicitAny in tsconfig. Need to fix the errors.

@imbhargav5 imbhargav5 added the help wanted Extra attention is needed label Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #1152 (f4cb6a2) into next (971bd3e) will decrease coverage by 0.06%.
The diff coverage is 96.07%.

@@            Coverage Diff             @@
##             next    #1152      +/-   ##
==========================================
- Coverage   91.17%   91.11%   -0.07%     
==========================================
  Files          69       70       +1     
  Lines        4103     4434     +331     
  Branches      682      731      +49     
==========================================
+ Hits         3741     4040     +299     
- Misses        360      392      +32     
  Partials        2        2              
Impacted Files Coverage Δ
src/hooks/useVisibilitySensor.ts 27.57% <36.36%> (-0.76%) ⬇️
src/hooks/useFullscreen.ts 77.39% <90.90%> (-0.92%) ⬇️
src/hooks/useSessionstorage.ts 91.12% <91.42%> (-4.84%) ⬇️
src/hooks/useDimensionsRef.ts 97.89% <92.85%> (+4.21%) ⬆️
src/hooks/useUndoState.ts 98.48% <96.87%> (-1.52%) ⬇️
src/hooks/useDebouncedValue.ts 100.00% <100.00%> (ø)
src/hooks/useFreshTick.ts 100.00% <100.00%> (ø)
src/hooks/useInput.ts 98.78% <100.00%> (-1.22%) ⬇️
src/hooks/useInterval.ts 97.02% <100.00%> (+1.07%) ⬆️
src/hooks/useKey.ts 100.00% <100.00%> (+1.14%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971bd3e...f4cb6a2. Read the comment docs.

@imbhargav5 imbhargav5 self-assigned this Jul 24, 2022
@imbhargav5 imbhargav5 added the v6 label Jul 24, 2022
@imbhargav5 imbhargav5 force-pushed the imbhargav5/engg-33-any-types-cleanup-in-rooks branch from 1ef61d6 to a3c9d1f Compare July 27, 2022 10:15
@imbhargav5 imbhargav5 removed the help wanted Extra attention is needed label Jul 27, 2022
@imbhargav5 imbhargav5 changed the base branch from main to next July 27, 2022 10:24
@imbhargav5 imbhargav5 merged commit 00362e3 into next Jul 27, 2022
@imbhargav5 imbhargav5 deleted the imbhargav5/engg-33-any-types-cleanup-in-rooks branch July 27, 2022 10:29
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

imbhargav5 added a commit that referenced this pull request Jul 29, 2022
* fix(types): remove any types (#1152)

* fix(types): remove any types

* chore(jest.config.js): use tsconfig pathmappings

* fix(usefreshtick): update callback types

* chore(settings.json): update settings to include eslint fix on save

* fix(usedimensionsref): update warning logic

* fix(useundostate): update types

* fix(usenavigatorlanguage): fix types

* fix(usethrottle): fix types

* chore(see): add see links

* fix(usekey): update types

* fix(usekeyref): update types

* fix(usesessionstorage): update types

* fix(useselectablelist): update types

* fix(useraf): update types

* fix(usemultiselectablelist): fix types

* fix(usekeybindings): fix types

* fix(usefullscreen): tsignore usefullscreen for now

* test: update test cases

* fix(types): remove any ambigiuous types wip

* fix(usetoggle): update types and add generics

* fix(usethrottle spec): update types in test cases

* fix(usetimeoutwhen): test cases

update test cases

* fix(usesessionstorage): update types in test cases

* test(useraf): update test case

* test(usepreviousimmediate): update test cases

* test(usepreviousdifferent): fix ts errors in tests

* test(useprevious): fix ts errors in tests

* test(useoutsideclickref): fix ts errors in tests

* test(useoutsideclick): fix ts errors in test

* test(useonline): fix ts errors in tests

* test(usenavigatorlanguage): fix ts errors in tests

* test(usemutationobserver): fix ts errors

* test(uselocalstorage): fix tests

* test(usekey): update tests and fix ts errors

* test(useinterval tests): update tests and fix ts errors

* test(update test cases): update tests

* fix: lint errors (#1179)

* chore(lint): fix eslint wip

* chore(lint and tsc): fixes

* fix(usemergerefs): fix types

* fix(usematchmedia): tsc and lint fixes

* chore(usemap): types

* chore(lint): fixes

* fix(deprecated): hooks removed

BREAKING CHANGE: useIntervalWhen, useLocalstorageState, usePreviousImmediate,
useSessionstorageState, useTimeoutWhen, useDidUpdate, useInViewRef hooks should be used instead.

* fix(index): remove unused

* fix(build): build fix

* fix(types): fixes

* fix(usefullscreen): ignore eslint errors for now

* fix(updates): update types and tests

* style(lint): fix lint errors

* chore(helpers): update helper scripts

* chore(cleanup): clean helpers

* chore(allcontributors): cleanup helpers

* test(generalssrtest): remove unnecessary tests
imbhargav5 added a commit that referenced this pull request Jul 30, 2022
* Next (#1180)

* fix(types): remove any types (#1152)

* fix(types): remove any types

* chore(jest.config.js): use tsconfig pathmappings

* fix(usefreshtick): update callback types

* chore(settings.json): update settings to include eslint fix on save

* fix(usedimensionsref): update warning logic

* fix(useundostate): update types

* fix(usenavigatorlanguage): fix types

* fix(usethrottle): fix types

* chore(see): add see links

* fix(usekey): update types

* fix(usekeyref): update types

* fix(usesessionstorage): update types

* fix(useselectablelist): update types

* fix(useraf): update types

* fix(usemultiselectablelist): fix types

* fix(usekeybindings): fix types

* fix(usefullscreen): tsignore usefullscreen for now

* test: update test cases

* fix(types): remove any ambigiuous types wip

* fix(usetoggle): update types and add generics

* fix(usethrottle spec): update types in test cases

* fix(usetimeoutwhen): test cases

update test cases

* fix(usesessionstorage): update types in test cases

* test(useraf): update test case

* test(usepreviousimmediate): update test cases

* test(usepreviousdifferent): fix ts errors in tests

* test(useprevious): fix ts errors in tests

* test(useoutsideclickref): fix ts errors in tests

* test(useoutsideclick): fix ts errors in test

* test(useonline): fix ts errors in tests

* test(usenavigatorlanguage): fix ts errors in tests

* test(usemutationobserver): fix ts errors

* test(uselocalstorage): fix tests

* test(usekey): update tests and fix ts errors

* test(useinterval tests): update tests and fix ts errors

* test(update test cases): update tests

* fix: lint errors (#1179)

* chore(lint): fix eslint wip

* chore(lint and tsc): fixes

* fix(usemergerefs): fix types

* fix(usematchmedia): tsc and lint fixes

* chore(usemap): types

* chore(lint): fixes

* fix(deprecated): hooks removed

BREAKING CHANGE: useIntervalWhen, useLocalstorageState, usePreviousImmediate,
useSessionstorageState, useTimeoutWhen, useDidUpdate, useInViewRef hooks should be used instead.

* fix(index): remove unused

* fix(build): build fix

* fix(types): fixes

* fix(usefullscreen): ignore eslint errors for now

* fix(updates): update types and tests

* style(lint): fix lint errors

* chore(helpers): update helper scripts

* chore(cleanup): clean helpers

* chore(allcontributors): cleanup helpers

* test(generalssrtest): remove unnecessary tests

* Imbhargav5/engg 46 move to turborepo and changesets (#1182)

* chore(turborepo): move to turborepo

* chore(turborepo): move to turborepo

* build(prettier): fix configuration

* build(scripts): update scripts

* build(script): fix create script

* build(website): docs scripts update

* chore(allcontributors): update action

* ci(actions): configure actions and workflows with changesets

* ci(workflows): fix typo

* ci: force build

* ci(turbo): turbo vercel

* chore(vercel.json): remove unnecessary file

* ci: force build

* ci(workflows): add update-package-list-to-markdown to contributors.yml

* ci(ci): workflow filter fix

* chore(add changeset): changeset added

* fix: ci

* Version Packages (alpha) (#1183)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: set publish access for rooks

* chore: Remark documentation (#1184)

* fix: website

* fix: website

* docs(website): improvements to website and docs

* chore: remove unused

* docs(website): improvements to website and docs

* chore(create script): introduce category for hooks

* fix: remove unnecessary import

* chore(categories): show categories better

* chore(readme): format readme

* docs(update docs): new docs pattern for all hooks

* chore(website): add home page

* test(imports): put back react imports

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant