Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMediaMatch): safari 13.1 addListener fix #1556

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

reflog
Copy link
Contributor

@reflog reflog commented Oct 25, 2022

This PR fixes a regression causing crashes in old Safari versions

@codesandbox
Copy link

codesandbox bot commented Oct 25, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Oct 25, 2022

@reflog is attempting to deploy a commit to the Rooks Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rooks ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 2:00PM (UTC)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 91.83% // Head: 91.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (366ffe6) compared to base (e597b7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   91.83%   91.84%           
=======================================
  Files          76       76           
  Lines        4900     4906    +6     
  Branches      824      825    +1     
=======================================
+ Hits         4500     4506    +6     
  Misses        400      400           
Impacted Files Coverage Δ
packages/rooks/src/hooks/useMediaMatch.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imbhargav5 imbhargav5 merged commit 2511d61 into imbhargav5:main Oct 26, 2022
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants