Skip to content

Move non-native cubit functionality out of wrapper #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isteinbrecher
Copy link
Collaborator

@isteinbrecher isteinbrecher commented Mar 31, 2025

This moves all utility functionality out of the cubit host class. This makes the CubitConnect more of a pure wrapper.

@isteinbrecher isteinbrecher marked this pull request as draft March 31, 2025 10:20
@isteinbrecher
Copy link
Collaborator Author

@m-frey @knarfnitram @maxfirmbach

For now the functions get_geometry_type and get_node_ids are moved completely out of the Cubit class. Are these functions used by you? We could alternatively mode them to directly to CubitPy (not the wrapper), then nothing in the current behaviour of how to use CubitPy would change.

@knarfnitram
Copy link
Collaborator

knarfnitram commented Mar 31, 2025

I am using get_geometry_type, I would still like to use it or a similar function.

@isteinbrecher
Copy link
Collaborator Author

The functionality will definitely remain, the question is, if we want to have a free function

get_geometry_type(cubit, item)

or we want to add this as a method to the CubitPy object

cubit.get_geometry_type(item)

I think I would actually prefer the second variant (then no external workflows will notice this change), I will change that in this PR.

@isteinbrecher isteinbrecher marked this pull request as ready for review April 1, 2025 16:09
@isteinbrecher isteinbrecher marked this pull request as draft April 1, 2025 16:16
@isteinbrecher
Copy link
Collaborator Author

Maybe this is not so simple after all... I will try some solutions once I have some time and then push here. Likely we will have to change the interface of get_geometry_type and get_node_ids (slightly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants