Skip to content

Commit

Permalink
Merge pull request prebid#28 in SA/prebid from feature/CAP-2516 to ma…
Browse files Browse the repository at this point in the history
…ster

* commit 'fe450e68a4ff3e6dc6267862b4888ea0ac3680e8':
  feature/CAP-2516: Remove the filtering of eids for synacormediaBidAdapter
  • Loading branch information
Tim Ace committed Jan 26, 2022
2 parents 00a11e4 + fe450e6 commit 0d4dd85
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 17 deletions.
18 changes: 1 addition & 17 deletions modules/synacormediaBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ const BLOCKED_AD_SIZES = [
'1x1',
'1x2'
];
const SUPPORTED_USER_ID_SOURCES = [
'liveramp.com', // Liveramp IdentityLink
'nextroll.com', // NextRoll XID
'verizonmedia.com', // Verizon Media ConnectID
'pubcid.org' // PubCommon ID
];
const DEFAULT_MAX_TTL = 420; // 7 minutes
export const spec = {
code: 'synacormedia',
Expand Down Expand Up @@ -96,7 +90,7 @@ export const spec = {

// User ID
if (validBidReqs[0] && validBidReqs[0].userIdAsEids && Array.isArray(validBidReqs[0].userIdAsEids)) {
const eids = this.processEids(validBidReqs[0].userIdAsEids);
const eids = validBidReqs[0].userIdAsEids;
if (eids.length) {
deepSetValue(openRtbBidRequest, 'user.ext.eids', eids);
}
Expand All @@ -115,16 +109,6 @@ export const spec = {
}
},

processEids: function(userIdAsEids) {
const eids = [];
userIdAsEids.forEach(function(eid) {
if (SUPPORTED_USER_ID_SOURCES.indexOf(eid.source) > -1) {
eids.push(eid);
}
});
return eids;
},

buildBannerImpressions: function (adSizes, bid, tagIdOrPlacementId, pos, videoOrBannerKey) {
let format = [];
let imps = [];
Expand Down
7 changes: 7 additions & 0 deletions test/spec/modules/synacormediaBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,13 @@ describe('synacormediaBidAdapter ', function () {
rtiPartner: 'TDID'
}
}]
},
{
source: 'neustar.biz',
uids: [{
id: 'neustar809-044-23njhwer3',
atype: 1
}]
}
];

Expand Down

0 comments on commit 0d4dd85

Please sign in to comment.