[refactor] ViewControllerFactory 구현부 DIContainer로부터 분리#154
Open
[refactor] ViewControllerFactory 구현부 DIContainer로부터 분리#154
Conversation
1 task
H0sungKim
requested review from
rosejinse and
soeun11
and removed request for
rosejinse
H0sungKim
commented
Jan 30, 2026
Contributor
Author
There was a problem hiding this comment.
extension ProtocolA: ProtocolB가 안되더라고요~~!!
그래서 꼼수로 where Self: AddContentSelectViewModelFactory & ViewControllerFactory
AddContentSelectViewModelFactory랑 ViewControllerFactory 채택하고 있는 애에서 AddContentSelectViewControllerFactory를 채택하면 해당 기본 구현을 제공해라~ 라고 만들었습니다.
이러면 이제 DIContainer: ViewControllerFactory & AddContentSelectViewModelFactory이렇게 채택만 해주면 makeAddContentSelectViewController()함수를 사용할 수 있어여~~!!!
Contributor
There was a problem hiding this comment.
상당히 고능코드군요 .. where self 배워갑니다 👍
soeun11
approved these changes
Feb 2, 2026
Contributor
soeun11
left a comment
soeun11
left a comment
There was a problem hiding this comment.
확실히 DIContainer랑 viewcontrollerFactory가 깔끔해지긴했네요 .. 이해잘한진모르겠는데 ^-^ 노력해볼게요
Contributor
There was a problem hiding this comment.
상당히 고능코드군요 .. where self 배워갑니다 👍
This was referenced Feb 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Related Issues
📋 Description
💬 To Reviewers