Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voxelization algorithm #7

Closed
wants to merge 1 commit into from
Closed

Add voxelization algorithm #7

wants to merge 1 commit into from

Conversation

ctrueden
Copy link
Member

Migrated from ImageJ Ops, including @kephale's work from imagej/imagej-ops#653.

Built on #6. Once that one merges, I will rebase this PR and promote it out of draft status.

@ctrueden
Copy link
Member Author

@kephale I noticed, while doing this work, that https://fileadmin.cs.lth.se/cs/Personal/Tomas_Akenine-Moller/code/ has three different versions of the code, tribox.txt, tribox2.txt (faster), and tribox3.txt (faster and less buggy). The page unambiguously recommends using the third version, but your comment in the code references tribox.txt. Have you had a look at the differences between these, and compared to your implementation? Should we take the lessons learned from the 2nd and 3rd versions of tribox and apply them here?

@kephale
Copy link
Contributor

kephale commented Sep 29, 2023

Definitely up for learning from the other versions as well. I would have expected that I checked out multiple versions at the time, but that was a long time ago now. The current changes have certainly diverged from the previous version. I haven't revisited the originals recently. For these updates I just tried out some strategies that seemed reasonable.

And improve the test to make varying the sphere radius simpler.

Migrated from imagej/imagej-ops#653.

See also imagej/imagej-ops#422.

Co-authored-by: Kyle Harrington <kephale@kyleharrington.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants