Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split IterableRegion #71

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Split IterableRegion #71

merged 3 commits into from
Apr 5, 2024

Conversation

tpietzsch
Copy link
Member

adresses #70

IterableRegion<T extends BooleanType<T>> no longer extends IterableInterval<Void>.
Instead, it exposes IterableInterval<Void> via the new inside() method.

The inside iterable is a view of the region. For example, re-positioning a PositionableIterableRegion will also re-position its inside() view, and vice versa.

@tpietzsch
POM: Bump parent to pom-scijava 37.0.0
6d34fc4
@tpietzsch
Split IterableInterval<Void> from IterableRegion
9373214 
The Cursor<Void> of the inside pixels of a region can be obtained by
region.inside().cursor() now.
ctrueden
ctrueden approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

The code duplication across some inner class implementations (e.g. the three nearly identical InsideIterable classes) bothers me, but it's all internal implementation details that could be refactored later.

src/main/java/net/imglib2/roi/util/IterableRegionOnBooleanRAI.java Outdated Show resolved Hide resolved
This was referenced Mar 28, 2024
Merged
Merged
@tpietzsch tpietzsch merged commit ec2d46d into master Apr 5, 2024
1 check passed
@tpietzsch tpietzsch deleted the split-iterable-region branch April 5, 2024 13:32
tpietzsch added a commit to imagej/imagej-ops that referenced this pull request Apr 5, 2024
@tpietzsch
Follow API changes from imglib/imglib2-roi#71
813b6a9
tpietzsch added a commit to tpietzsch/TrackMate that referenced this pull request Apr 5, 2024
@tpietzsch
Addapt API changes introduced by imglib/imglib2-roi#71
6264cb7
@tpietzsch tpietzsch mentioned this pull request Apr 5, 2024
Merged
tpietzsch added a commit to tpietzsch/TrackMate-Skeleton that referenced this pull request Apr 5, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
db4e328
@tpietzsch tpietzsch mentioned this pull request Apr 5, 2024
Merged
tpietzsch added a commit to juglab/labkit-pixel-classification that referenced this pull request Apr 5, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
0659a63
tpietzsch added a commit to juglab/labkit-ui that referenced this pull request Apr 5, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
b4c78f8
ctrueden pushed a commit to imagej/imagej-ops that referenced this pull request Jun 11, 2024
@tpietzsch @ctrueden
WIP: Update to ImgLib2 v7
ccb600e 
Depends on upgrade of imagej-common.

* Add missing getType() implementations
* Follow API changes from imglib/imglib2-roi#71

Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
tpietzsch added a commit to juglab/labkit-ui that referenced this pull request Aug 19, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
1db7ae7
tpietzsch added a commit to juglab/labkit-pixel-classification that referenced this pull request Aug 28, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
548ed74
tpietzsch added a commit to imagej/imagej-ops that referenced this pull request Aug 28, 2024
@tpietzsch
Fix remaining compile error (related to imglib/imglib2-roi#71)
07c65b9
tpietzsch added a commit to tpietzsch/TrackMate that referenced this pull request Aug 28, 2024
@tpietzsch
Addapt API changes introduced by imglib/imglib2-roi#71
3ee3a7b
tpietzsch added a commit to tpietzsch/TrackMate that referenced this pull request Aug 28, 2024
@tpietzsch
Addapt API changes introduced by imglib/imglib2-roi#71
5e0af52
tpietzsch added a commit to tpietzsch/TrackMate-Skeleton that referenced this pull request Aug 28, 2024
@tpietzsch
Adapt API changes introduced by imglib/imglib2-roi#71
0477fcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrueden ctrueden ctrueden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpietzsch @ctrueden