fix: getUseWebGPU function that fallbacks to cpu when no gpu adapter is available #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is available with await
Renamed function to fit naming conventions
|
Thanks for the PR. I integrated the fix into the capability detection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation hints at a GPU-to-CPU fallback, but doesn't make it explicit
Reading the code you can understand that there is a check about the existence of "navigator.gpu" but this check does not catch cases where there is no adapter available. In these cases, a runtime error occurs within the onnxruntime-web lib.
This PR also aims to check the existence of an adapter and make this behavior explicit in the documentation