Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues #18 and #19 with Z pie eating key inputs #27

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

tmilker
Copy link
Contributor

@tmilker tmilker commented Dec 9, 2023

This fix incorporates some of @dc1248's changes mentioned in the comments of #18. However, their fixes alone did not solve the issue because the letter z input was still being consumed when the focus wasn't in the 3D view(like in the Groups' text input field). This takes a new approach to determine if the 3D viewport has focus and only trigger then, correcting both #18 and partially corrects #19.

This pull request does not address the 2nd item of #19 where the pie is still active but invisible upon a second keypress.

Fix #18

@imjp94
Copy link
Owner

imjp94 commented Dec 10, 2023

Thanks for the effort!
Let me know if you want to include the fix for "invisible pie menu", otherwise it is good to go.

@tmilker
Copy link
Contributor Author

tmilker commented Dec 10, 2023

@imjp94 I don't think I'm going to try tackling the pie issue at this time. Maybe that one could be broken out into a new issue.

@imjp94
Copy link
Owner

imjp94 commented Dec 10, 2023

Gotcha, thank you!

@imjp94 imjp94 merged commit cb9f535 into imjp94:master Dec 10, 2023
@dc1248
Copy link

dc1248 commented Dec 21, 2023

Thanks @tmilker !

As for #19 I'll test it again now that Godot 4.2 is out, and maybe I'll take another stab at the unsolved parts. It would really to nice to make the pie menu mouse/keyboard UI work exactly like Blender's if possible in Godot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z shortcut is active in 2D, script editor, etc
3 participants