Proxy: Ignore setting a reference to itself #690
Conversation
smirea
force-pushed
the
proxy-set-ignore-equality
branch
from
6991d82 to
3892e4d
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 462f506:
|
|
Please make sure that tests proof what was suboptimal before, and works better now |
|
@smirea do you intend to work on this PR further in the future? |
|
oh hey, missed your previous comment, sure I can add tests to it and submit it properly, I just wasn't sure if that was the right approach |
|
Me neither until I see which problem it fixes ;-)
…On Tue, Nov 17, 2020 at 4:34 PM Stefan Mirea ***@***.***> wrote:
oh hey, missed your previous comment, sure I can add tests to it and
submit it properly, I just wasn't sure if that was the right approach
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#690 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBDYB37UD2V5ZJ77WVLSQKQZ7ANCNFSM4SZ6RTGQ>
.
|
|
ok updated the PR with a test outlining the issue if you can take another look |
|
@mweststrate I added the test, mind giving it another look? This is related to #648 |
|
🎉 This PR is included in version 8.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.