Expand and revise examples section #89
Conversation
|
/agenda |
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
…of the order of precedence.
…ion discussed rather than a single binary attribute
|
@DRx3D I've updated the attribute for providing orbit input from |
|
@DRx3D After some investigation and discussion, it seems that a top-level |
| Loading and parsing | ||
| </h3> | ||
| <p> | ||
| A model element whose source path resolves to a valid resource |
There was a problem hiding this comment.
I'm not sure there's a lot of value to adding this example here because it's so limited (plus it doesn't really deal with "loading or parsing", just very simple error handling). Consider that, like any event handling element, the element will deal (in one way or another) with all these event handler attributes:
https://html.spec.whatwg.org/#event-handlers-on-elements,-document-objects,-and-window-objects
Also, if we end up treating these elements as akin to media elements, then we might end up using these error codes, etc.:
https://html.spec.whatwg.org/#error-codes
I'd be inclined to either rename this section "Error handling" or removing it entirely until we figure out if model is a media element.
index.html
Outdated
| <aside class="note"> | ||
| The bounding box and sphere is often computed based on the visible object | ||
| hierarchy on the first animation frame (if an animation is present), | ||
| and according only to the geometry information directly specified. |
There was a problem hiding this comment.
nit: "specified" by who? (can we change this to active voice?)
There was a problem hiding this comment.
updated to reflect that rendering contexts generally compute it this way - it may need to be called out as non-normative or otherwise an observation of the state of the art.
| Processing model contents | ||
| </h3> | ||
| <p data-cite="infra geometry-1" > | ||
| A 3D asset file contains positional data for the surfaces and objects |
There was a problem hiding this comment.
The text in this section feels more like spec text than an example (it's a bit uncommon to talk about how the internals work in an example)... I wonder if we should move this or actually simplify all this into an example of usage?
There was a problem hiding this comment.
@marcoscaceres I think it's not example content at all, yeah - I'll pull it out of this PR. Is there a good section name / description of this kind of content you'd recommend instead?
index.html
Outdated
| <pre class="html"> | ||
|
|
||
| <figure> | ||
| <model alt="A gray, ceramic teapot with an innovative spout" > |
There was a problem hiding this comment.
I still think we should get rid of alt=... the html around it or inside the element provides way better and more accessible fallback content (eg., <figurecaption>).
…ommon practice for general rendering contexts to do this.
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
Co-authored-by: Marcos Cáceres <caceres_m@apple.com>
…bjects, updated the diagram to reflect this priority
Added the examples already sketched out in the document and added some more based on a tentative approach to MVP functionality.
Preview | Diff