Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAG Feedback: Code sample for handling WebGL context loss #826

Closed
toji opened this issue Sep 4, 2019 · 1 comment · Fixed by #890
Closed

TAG Feedback: Code sample for handling WebGL context loss #826

toji opened this issue Sep 4, 2019 · 1 comment · Fixed by #890
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Milestone
October 2019

Comments

@toji
Copy link
Member

toji commented Sep 4, 2019

As requested in w3ctag/design-reviews#403 (comment)

The feedback we've received from the TAG raised the issue that while our explainer demonstrates how to create a WebGL context that is XR compatible from creation time, it does not demonstrate how to properly handle context loss in the code sample for gl.makeXRCompatible(). Given that this is a critical part of using the method, we should ensure that the code sample reflects it.
@toji toji added editor triage Issues marked for triage/re-examination by the editors help wanted This is a good issue for anyone to pick up and work on filing a PR for. labels Sep 4, 2019
@toji toji mentioned this issue Sep 5, 2019
Closed
5 tasks
@NellWaliczek NellWaliczek added this to the Spec-Complete for 1.0 milestone Sep 5, 2019
@toji toji removed the editor triage Issues marked for triage/re-examination by the editors label Sep 9, 2019
@toji toji mentioned this issue Oct 17, 2019
Merged
@probot-label
Copy link

probot-label bot commented Oct 17, 2019

This issue is fixed by PR #890

@probot-label probot-label bot added the fixed by pending PR A PR that is in review will resolve this issue. label Oct 17, 2019
@toji toji closed this as completed in #890 Oct 18, 2019
toji added a commit that referenced this issue Oct 18, 2019
@toji
Add sample demonstrating context loss handling (#890)
520e1aa 
/fixes #826

Shuffles the surrounding text a bit too to help it flow with the new sample code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Add sample demonstrating context loss handling immersive-web/webxr
2 participants
@toji @NellWaliczek