Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SameObject attribute from skipRendering #1382

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove SameObject attribute from skipRendering #1382

merged 1 commit into from
Aug 21, 2024

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Aug 21, 2024 •
edited by pr-preview bot
Loading

Per WebIDL spec,

The [SameObject] extended attribute must not be used on anything other than a read only attribute whose type is an interface type or object.

skipRendering is a boolean, so it isn't eligible. Encountered while updating Servo and getting an error during codegen

Preview | Diff

toji
toji approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you! Clearly just a copy-paste typo.

@w3cbot
Copy link

w3cbot commented Aug 21, 2024

toji marked as non substantive for IPR from ash-nazg.

@toji toji merged commit 67d74cd into immersive-web:main Aug 21, 2024
2 checks passed
@msub2 msub2 deleted the skiprendering branch August 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msub2 @w3cbot @toji