Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): add default grafana dashboards as configmap #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hiteshnayak305
Copy link
Contributor

Description of the change

Add a default grafana dashboard as configmap which can be provisioned in grafana stack (grafana + prometheus + loki + promtail).

Ref: https://github.com/grafana/helm-charts/tree/main/charts/grafana#sidecar-for-dashboards

Applicable issues

Dashboard Preview

image

@hiteshnayak305 hiteshnayak305 marked this pull request as draft October 20, 2024 00:42
@hiteshnayak305 hiteshnayak305 marked this pull request as ready for review October 20, 2024 00:43
@bo0tzz
Copy link
Member

bo0tzz commented Oct 20, 2024

Cool! I think if we're gonna have a dashboard for Immich, it should probably live somewhere more centrally and then get pulled into the chart.

@hiteshnayak305
Copy link
Contributor Author

Cool! I think if we're gonna have a dashboard for Immich, it should probably live somewhere more centrally and then get pulled into the chart.

I checked with generics charts like prometheus, grafana most of them have packaged in helm repository and managed. Or we can try Grafana Lab.

@bo0tzz
Copy link
Member

bo0tzz commented Oct 20, 2024

The intent behind my suggestion is that the dashboard can be useful for more than just the helm chart, so it might make more sense to keep it in the main immich repository (though I'm not quite sure where yet). We can then have the helm chart include it from there though.

@hiteshnayak305
Copy link
Contributor Author

yes i also agree with central location for dashboards management. but in this dashboard i have used namespace as label paramater so we will need to create another generic dashboard if want to use outside kubernetes cluster.
or namespace label need to be set manually for standalone deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grafana dashboard provisioned with Helm
2 participants