Skip to content

Commit

Permalink
fix(server): database backups compatible with deduplication (#13965)
Browse files Browse the repository at this point in the history
gzip --rsyncable has a slightly worse compression ratio, but allows for
efficient deduplication and, as the name implies, faster rsync
operations.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
  • Loading branch information
Scrumplex authored Nov 7, 2024
1 parent f4741c7 commit 564449a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion server/src/services/backup.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ export class BackupService extends BaseService {
env: { PATH: process.env.PATH, PGPASSWORD: isUrlConnection ? undefined : config.password },
});

const gzip = this.processRepository.spawn(`gzip`, []);
// NOTE: `--rsyncable` is only supported in GNU gzip
const gzip = this.processRepository.spawn(`gzip`, ['--rsyncable']);
pgdump.stdout.pipe(gzip.stdin);

const fileStream = this.storageRepository.createWriteStream(backupFilePath);
Expand Down

0 comments on commit 564449a

Please sign in to comment.