-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): country geocoding for remote locations #10950
feat(server): country geocoding for remote locations #10950
Conversation
f97d14d
to
9b0e9a8
Compare
203d1f3
to
9b20af2
Compare
9b20af2
to
96a7dbb
Compare
4fa7d0d
to
c6920f5
Compare
@@ -134,7 +138,29 @@ export class MapRepository implements IMapRepository { | |||
this.logger.warn( | |||
`Response from database for reverse geocoding latitude: ${point.latitude}, longitude: ${point.longitude} was null`, | |||
); | |||
return null; | |||
|
|||
const ne_response = await this.naturalEarthCountriesRepository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the above condition to return if it has a response. Then, de-indent all of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the code. Definitely makes it clearer!
What needs to be done after an upgrade to 1.109 in order to make use of this for existing images? |
Re-running the extract metadata job for all images should do it 🙂 |
Thanks! I think this would be worth mentioning in the changelog/release notes for such kind of change, thanks for helping! Much appreciated! |
Add country reverse geocoding in case city geocoding is null. Uses country boundaries from Natural Earth
Dependencies
base-images PR: immich-app/base-images#80
Database changes:
Server changes:
Note - this uses the current geocoding state metadata for DB import
Web UI changes: