fix(server): wrong image dimensions for RAW files (RAF, CR2) (also fixes face preview) #13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Otto
force-pushed
the
raw-dimensions
branch
2 times, most recently
from
7cf1c59
to
cca0135
Compare
3 tasks
mertalev
approved these changes
Oct 11, 2024
|
I'll have a look at your suggestions, thanks. While other weird RAW formats keep popping up, I'm pausing work on this (see discussion in #13049). |
C-Otto
force-pushed
the
raw-dimensions
branch
3 times, most recently
from
deeb445
to
96eec57
Compare
mertalev
reviewed
Oct 14, 2024
C-Otto
force-pushed
the
raw-dimensions
branch
from
cc6ac7a
to
7722769
Compare
C-Otto
changed the title
C-Otto
force-pushed
the
raw-dimensions
branch
from
7722769
to
f318772
Compare
C-Otto
force-pushed
the
raw-dimensions
branch
from
f318772
to
6e85360
Compare
C-Otto
changed the title
|
@mertalev 🚀? |
C-Otto
force-pushed
the
raw-dimensions
branch
2 times, most recently
from
694ee81
to
2737aab
Compare
Added Fujifilm X100v RAF RAW File fix(server): prefer ImageSize over ImageWidth/Height metadata For some RAW formats/cameras, the ImageWidth/ImageHeight information represents the dimensions of the preview image, i.e. much smaller than the actual image. This also causes issues with (face/people) thumbnail generation. The information in ImageSize seems to be correct, so we use this instead. fixes #13049
mertalev
approved these changes
Nov 1, 2024
TimVanOnckelen
pushed a commit
to TimVanOnckelen/immich
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some RAW formats/cameras, the ImageWidth/ImageHeight information represents the dimensions of the preview image, i.e. much smaller than the actual image. This also causes issues with (face/people) thumbnail generation. The information in ImageSize seems to be correct, so we use this instead.
fixes #13049