Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show warning when running main branch build #13462

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat: show warning when running main branch build #13462

merged 4 commits into from
Oct 17, 2024

Conversation

bo0tzz
Copy link
Member

@bo0tzz bo0tzz commented Oct 15, 2024

image
image

jrasm91
jrasm91 reviewed Oct 15, 2024
View reviewed changes
web/src/lib/i18n/en.json Outdated Show resolved Hide resolved
@bo0tzz bo0tzz force-pushed the feat/main-warning branch 2 times, most recently from 94f4a0d to 35f1fbd Compare October 16, 2024 13:31
jrasm91
jrasm91 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Did we want the conditions to be the same in both places? Right now it is source ref in one and repo and source ref in the other.

@bo0tzz
Copy link
Member Author

bo0tzz commented Oct 17, 2024

Woops, missed that one, ty.

@jrasm91 jrasm91 merged commit 79acbc1 into main Oct 17, 2024
36 checks passed
@jrasm91 jrasm91 deleted the feat/main-warning branch October 17, 2024 12:36
yosit pushed a commit to yosit/immich that referenced this pull request Oct 17, 2024
@bo0tzz @yosit
feat: show warning when running main branch build (immich-app#13462)
4f332af 
* feat: show warning when running main branch build

* fix: emoji weirdness

* fix: use icon instead of emoji

* fix: missing conditional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
changelog:enhancement 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bo0tzz @jrasm91 @danieldietzler