Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update _storage-template.md #13578

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

chriskoch
Copy link
Contributor

The example for the {{if}} was a little bit confusing. Just a recommendation

The example for the {{if}} was a little bit confusing. Just a recommendation
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2024
@alextran1502
Copy link
Contributor

Thanks for the suggestion. Have you tried testing the syntax and confirming it is working as expected?

@chriskoch
Copy link
Contributor Author

Yes just for clarification: The old example:

{{y}}/{{#if album}}{{album}}{{else}}Other/{{MM}}{{/if}}/{{filename}}

will create a path like

2024/MyAlbum/IMG665.jpg

if an album exists and

2024/Other/10/IMG665.jpg

if not. Means /MM will only be added if there is no album - what is confusing.

The suggestion moves the {{/if}} to the album only.

{{y}}/{{#if album}}{{album}}{{else}}Other{{/if}}/{{MM}}/{{filename}}

results the in

2024/MyAlbum/10/IMG665.jpg
2024/Other/10/IMG665.jpg

which brings clarity.

Chris

@alextran1502 alextran1502 changed the title Update _storage-template.md chore(docs): update _storage-template.md Oct 18, 2024
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris!

@alextran1502 alextran1502 enabled auto-merge (squash) October 18, 2024 19:41
@alextran1502 alextran1502 merged commit 76c0b96 into immich-app:main Oct 18, 2024
33 of 35 checks passed
yosit pushed a commit to yosit/immich that referenced this pull request Oct 24, 2024
Update _storage-template.md

The example for the {{if}} was a little bit confusing. Just a recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:documentation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants