fix(server): encodes iPhone 16 Pro video with unknown audio codec #13593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
approved these changes
Oct 18, 2024
|
Could you add a unit test for this? |
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 24, 2024
…mich-app#13593) * fix(server): encodes iPhone 16 Pro video with unknown audio codec * remove white space * pr feedback + unit test * remove public method keyword * test the service * correcting unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for missing new audio codec from iPhone 16 Pro Max in FFmpeg build by picking the known codec in the audio streams.
Tested on FireFox on video that previously doesn't play because of missing encoded video, now can play successfully with sound