Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move weblate translations to root directory #13604

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented Oct 19, 2024

Description

Move the Weblate translations into the root directory of the repository. This starts setting the groundwork for mobile and web to share the same translations.

Moving the translation JSON files is in its own commit, in case any changes are needed.

How Has This Been Tested?

  • All PR checks are passing
  • Check that immich-server runs as expected when using the immich-server:pr-13604 image
  • Dev server for web works, using make dev and make dev-update

@ben-basten
Copy link
Member Author

A couple of open questions:

  • Are JSON files with ICU message formatting the desired direction for mobile?
  • Should country codes be added to the translation files?

@jrasm91
Copy link
Contributor

jrasm91 commented Oct 21, 2024

A couple of open questions:

  • Are JSON files with ICU message formatting the desired direction for mobile?
  • Should country codes be added to the translation files?

For 1, I believe so. For 2, I have no idea, but maybe eventually. Just moving them to the top level is a good start.

@ben-basten
Copy link
Member Author

For 1, I believe so. For 2, I have no idea, but maybe eventually. Just moving them to the top level is a good start.

Ok, just figured I'd check. From what I can tell, it doesn't look like the current mobile easy_localization library supports ICU formatting.

@jrasm91 jrasm91 enabled auto-merge (squash) October 22, 2024 15:25
@jrasm91 jrasm91 merged commit e98acc9 into main Oct 22, 2024
36 checks passed
@jrasm91 jrasm91 deleted the chore/move-translations branch October 22, 2024 15:39
yosit pushed a commit to yosit/immich that referenced this pull request Oct 24, 2024
* chore: move translations to root directory

* chore: update build processes to work with new i18n location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants