-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Album preview overview in menu #13981
Open
TimVanOnckelen
wants to merge
14
commits into
immich-app:main
Choose a base branch
from
TimVanOnckelen:feat/album-dropdown-web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(web): Album preview overview in menu #13981
TimVanOnckelen
wants to merge
14
commits into
immich-app:main
from
TimVanOnckelen:feat/album-dropdown-web
+2,639
−3,023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements part of #8743 |
Hello, thanks for the PR. I am working on migrate the whole web codebase to the new rune syntax so new features on the web will have to wait 😅 |
Np, ofcourse! Where possible, i used your changes on the rune syntax from your pr #13883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a visual overview of the three latest albums in the main menu, similar to the App-Which-Must-Not-Be-Named. The addition provides quick album previews for users, enhancing navigation and user experience.
Changes Overview:
Album Menu Extension: Added a visual preview of three albums directly within the Album menu for quick access.
New Optional Parameter in API: Introduced top as an optional parameter in the /albums (getAllAlbums) route, allowing flexible limits on album retrieval.
Technical Details:
The top parameter supports optimized retrieval of album data by limiting results, enhancing efficiency for both UI rendering and API load.
The visual display integrates seamlessly with the existing menu styling, ensuring consistent user experience.