-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): exclude locales from overpass font #14158
feat(mobile): exclude locales from overpass font #14158
Conversation
This provider can be used to refresh providers that provide UI elements and get cached.
navigatorObservers: () => [TabNavigationObserver(ref: ref)], | ||
return ProviderScope( | ||
overrides: [ | ||
localeProvider.overrideWithValue(context.locale), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this overrides
property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sets the localeProvider
value for the rest subtree of widgets every time that context.locale
gets updated. Do you have an alternative way of settings the initial value of localeProvider
and then updating it?
Serbian Cyrillic has the issue too: #11216, could be added now. |
Ok I will update it to filter with region/country subtag and exclude |
Have you tested that the localeProvider's value never changes? Because I can't reproduce it. When the EasyLocalization parent widget rebuilds the localeProvider's value gets updated. Let me explain why I added this provider:
|
d0118bc
to
de5f7b3
Compare
* feat(mobile): create localeProvider This provider can be used to refresh providers that provide UI elements and get cached. * feat(mobile): use default font for locales not supported by Overpass * chore(mobile): fix test * refactor(mobile): use Locale instead of String
Fixes #10436
As mentioned here this PR adds a list of languages that should be excluded from using Overpass as a font. These languages will use the default Flutter font based on the platform.
As of right now the only known to me language having a problem is Greek, feel free to exclude more if needed.