Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #13555 add server cert field, similar to client cert #14335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crisoagf
Copy link

Initial code for server certificate field.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile

@zackpollard
Copy link
Contributor

Hey, could you please provide more information on what this is supposed to achieve?

@crisoagf
Copy link
Author

Hey, could you please provide more information on what this is supposed to achieve?

Sure thing!

This is an attempt to implement certificate selection for self-signed/enterprise-signed servers without simply disabling SSL certificate checking. It creates another settings field, similar to the client certificate selection, to import a root or self-signed certificate and use that for connection validation. AFAICT, this is only needed for Android, for iPhones already respect user imported certificates.

Currently, the only option for custom root certs or self-signed certs in Android is "Allow self-signed SSL certificates" that accepts any certificate that matches the hostname, which is at least a bit scary from an MITM attack perspective.

Context is #13555 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants