fix: out of memory error when uploading large assets on slow internet #224
Conversation
| 'assetData': [assetRawUploadData] | ||
| }); | ||
| if(thumbnailUploadData != null) { | ||
| req.files.add(thumbnailUploadData); |
There was a problem hiding this comment.
I like this, it makes the code cleaner
|
So the cancelation mechanism is not implemented for The most sensible way is to set a boolean to return the function after the current asset is finished uploading. This is a trade-off to handle the crashing issue and I think the trade-off is something we can live with until they have better implementation of the |
|
It might be good to implement this library which uses Dio and uploads large files in chunk https://github.com/Taskulu/chunked_uploader/blob/master/lib/chunked_uploader.dart to keep all the functionality of Dio |
zackpollard
force-pushed
the
fix/out-of-memory-asset-backup
branch
from
11d88cd to
b42082c
Compare
|
I fixed a bug that after canceling the upload, it keeps looping once catching the error. This is good for merging now. |
This is a fix for an out of memory exception caused by uploading large assets on slow internet. Size of asset that would cause this varies based on the device.
This should should fix #54 and fix #190