fix(mobile): fix forgetting backup albums (#3108) #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Can you add a few lines to the PR description on how this change has been tested |
Added. Is it sufficient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/workaround for #3108. It seems the bug is caused by a weird behaviour / bug in photo_manager: Sometimes
AssetPathEntity.fromIdthrows even when called with a valid asset id (say one returned from a previous call toPhotoManager.getAssetPathList).This PR works around that by looking the assets up in a previously obtained map instead of calling
AssetPathEntity.fromId.How has this been tested
Manually, by deploying the patched app to my phone with
flutter runand then going through the repro steps.