Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): refactor and add album support #4434

Merged
merged 44 commits into from
Nov 19, 2023
Merged

feat(cli): refactor and add album support #4434

merged 44 commits into from
Nov 19, 2023

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Oct 11, 2023

  • Deploy CLI as npm package @immich/cli
  • Remove read-only asset support
  • Add support for automatic album creation
  • Pull supported file extensions from server
  • Improved documentation
  • Use SDK instead of manual calls
  • Make server-info command richer

How this has been tested:

  • Uploading various folders to immich
  • Verifying created albums are as expected

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 8:39am

cli/README.md Outdated Show resolved Hide resolved
@etnoy etnoy changed the title feat(cli): get new cli production-ready feat(cli): refactor and add album support Nov 10, 2023
@etnoy etnoy marked this pull request as ready for review November 10, 2023 23:52
@alextran1502
Copy link
Contributor

Hello @etnoy, thank you for your continuous work on this. I just tested the PR and saw an issue about album creation.

Here is what the file systems look like

image

In Cute and With Da Space there are more assets.

Here is the command I used

image

When they get uploaded to the server, here is the result in the Albums tab

image

And here is one of the album's name

image

So I guess the album was created based on the absolute path of the file.

I expected there will be two album that get created namely Cute and With Da Space while the rest that are not in any folder would not be put into any album

@etnoy
Copy link
Contributor Author

etnoy commented Nov 15, 2023

Hello @etnoy, thank you for your continuous work on this. I just tested the PR and saw an issue about album creation.

Here is what the file systems look like

image

In Cute and With Da Space there are more assets.

Here is the command I used

image

When they get uploaded to the server, here is the result in the Albums tab

image

And here is one of the album's name

image

So I guess the album was created based on the absolute path of the file.

I expected there will be two album that get created namely Cute and With Da Space while the rest that are not in any folder would not be put into any album

Thanks for testing. This might be a Windows issue, it works on Linux. Also, I copied the logic from the legacy CLI so the same issue is likely they're too. Will look into this later today

@etnoy
Copy link
Contributor Author

etnoy commented Nov 16, 2023

Hello @etnoy, thank you for your continuous work on this. I just tested the PR and saw an issue about album creation.

Here is what the file systems look like

image

In Cute and With Da Space there are more assets.

Here is the command I used

image

When they get uploaded to the server, here is the result in the Albums tab

image

And here is one of the album's name

image

So I guess the album was created based on the absolute path of the file.

I expected there will be two album that get created namely Cute and With Da Space while the rest that are not in any folder would not be put into any album

I've added a check for windows, try again :)

@etnoy etnoy mentioned this pull request Nov 17, 2023
@etnoy etnoy added the cli Tasks related to the Immich CLI label Nov 17, 2023
@alextran1502
Copy link
Contributor

alextran1502 commented Nov 19, 2023

Looks good to me, can you help fix the documentation build error?

image

Then feel free to merge

@etnoy etnoy enabled auto-merge (squash) November 19, 2023 22:15
@etnoy etnoy merged commit 7e38e7c into main Nov 19, 2023
17 checks passed
@etnoy etnoy deleted the feat/cli-albums branch November 19, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Tasks related to the Immich CLI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants