-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mobile): maplibre #6087
Conversation
Deploying with
|
Latest commit: |
cae09f9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://cf24e34f.immich.pages.dev |
Branch Preview URL: | https://refactor-mobile-maplibre.immich.pages.dev |
@shenlong-tanwen Thank you for the PR. It works very well on an actual iOS device, the map tile is now loading instantly. I notice a few issues
|
0d05f2b
to
206116c
Compare
Let me check if there is something we can do to improve it. We can take this as a non-blocker and can handle it in a separate PR though. Can you check if double tap to zoom suffers from the same issue as well? On android, both seem fine to me.
I tried scrolling through the home page few times but cannot reproduce this. Is there anything I can do to reproduce it consistently?
This was not implemented then. I've added it back now |
Do you plan to consolidate location pin image with the web version? |
The refactoring includes a new pic but this is still different than the web version though. |
I cannot reproduce this on my end. Can you please check if #6553 fixes it for you? |
Will try tomorrow, thanks. |
Seems to be fixed with #6553. |
Changes made:
TODO: