fix(mobile): Fix iOS swipe not paging #6726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyfuhry
force-pushed
the
fix/ios-swipe-not-paging
branch
from
13c1de9 to
a11bfe5
Compare
Deploying with
|
| Latest commit: |
0152132
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c3a9f3e.immich.pages.dev |
| Branch Preview URL: | https://fix-ios-swipe-not-paging.immich.pages.dev |
|
I just tested this against |
|
I am still seeing the double swipe issue on my phone when the asset is remote + Local |
|
Closing because this is fixed in #7016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onPageChangefunction in the gallery was updating two watchedValueNotifiers which caused a race condition on iOS to not move the page every time. At least, this is our best approximation of what is happening.The fix was to combine those two indices into a single watched object with a
copyWithmethod to recreate it. I'm still able to reproduce the issue intermittently, so there may still be additional rebuilds caused by race conditions in the watched parameters.