refactor: authentication on public routes #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b6b1c52
|
| Status: | ⚡️ Build in progress... |
martabal
force-pushed
the
refactor/authentication-public-routes
branch
2 times, most recently
from
5a077e8
to
70f84c9
Compare
jrasm91
requested changes
Jan 30, 2024
martabal
force-pushed
the
refactor/authentication-public-routes
branch
2 times, most recently
from
60febd8
to
c748d54
Compare
jrasm91
reviewed
Jan 30, 2024
jrasm91
reviewed
Jan 30, 2024
martabal
force-pushed
the
refactor/authentication-public-routes
branch
2 times, most recently
from
2b53107
to
6647a57
Compare
danieldietzler
approved these changes
Feb 3, 2024
web/src/lib/components/user-settings-page/user-profile-settings.svelte
Outdated
Show resolved
Hide resolved
jrasm91
reviewed
Feb 11, 2024
web/src/lib/utils/auth.ts
Outdated
|
|
||
| if (!user) { | ||
| redirect(302, AppRoute.AUTH_LOGIN); | ||
| if (options.public && !user) { |
There was a problem hiding this comment.
why do you care if the user is defined or not if the route is public?
There was a problem hiding this comment.
it seems like you want:
- if public return we're done with all the checks
- if not user, redirect to login, this is an auth required route
- if admin route and not an admin, redirect to /photos
jrasm91
force-pushed
the
refactor/authentication-public-routes
branch
from
5a9af37
to
b6b1c52
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the authentication on public routes to avoid 400 requests on shared links